Payton Burdettechanged title from Frontend: Build google cloud connection section - Part two to Frontend: Build google cloud inputs component - Part two
changed title from Frontend: Build google cloud connection section - Part two to Frontend: Build google cloud inputs component - Part two
@pedroms I'm working on this issue and had a few questions.
For the cloud connection form.
Are we putting each of these blocks into gl-form-group components?
For the inputs, I see we are using description prop but building a custom label, instead of using label prop for form groups. Do we want to do this, or should we follow how the components are built and use the description prop.
I was building out a structure like so, but was not sure if we wanted this all to be in a form for ease of styling. Since the button elements are common form elements. Thanks!
@jivanvl can I also get your opinion on this Would it make sense to put all these "non-common" form elements within a gl-form-group?
Say if we get down to the "Project for runner" portion of the form, we would have to create a whole new form for the last input to retain the UI structure if we did not put them all in a form.
@pedroms@jivanvl Okay as far as I can tell we don't want to put the non form elements in a form group. Doesn't look like a good pattern...
I think we might should consider moving both of the drawer buttons beside each other so we can only mount one form here for the google cloud connection.
I think we might should consider moving both of the drawer buttons beside each other so we can only mount one form here for the google cloud connection.
Agreed, we should keep form-group components consistent with our guidelines, lest we open ourselves to more technical debt
@pburdette FYI the field within the “Workload identity federation” (WLIF) section for the “Google Cloud project ID” is now “Google Cloud project IDnumber” because that's the kind of value we need for WLIF (context, if needed). The project ID field with the “Project for runner” section stays the same. See Figma, asking for the WLIF project number. The “Where's my project number?” links to this Google Cloud docs page.