Follow-up from "Profile layout update"
The following discussions from !139707 (merged) should be addressed:
-
@dstull started a discussion: suggestion (non-blocking):
for follow-up...
There is a lot of ruby logic in this template. We should try to leverage things like helpers or ViewComponent to clean this up and get a more simplified view of the html itself and enhance our ability to test this programmatically. As this file currently stands...it really can only be fully verified manually.
As it is mostly existing and merely being moved around, this is fine...I think.
-
@dstull started a discussion: suggestion (non-blocking):
We should look at replacing these with data-testids in a follow-up.
-
@dstull started a discussion: suggestion (non-blocking):
for follow-up should replace with data-testid
-
@dstull started a discussion: suggestion (non-blocking):
for follow-up replace with data-testid
-
@dstull started a discussion: suggestion (non-blocking):
for follow-up replace with data-testid
-
@dstull started a discussion: suggestion (non-blocking):
for follow-up replace with data-testid
-
@dstull started a discussion: suggestion (non-blocking):
for follow-up replace with data-testid