On /admin/application_settings/general "General" tab isn't active

Summary

On /admin/application_settings/general the "General" tab on the nav sidebar isn't marked as active.

Steps to reproduce

  1. Go to Admin Area.
  2. On the sidebar navigate your cursor on "Settings", then on popup menu click "General".
  3. You're on /admin/application_settings/general page. Look at the "Settings" section on the sidebar.

What is the current bug behavior?

"General" tab isn't marked as an active tab.

What is the expected correct behavior?

"General" tab should be marked as an active tab.

Relevant logs and/or screenshots

Screenshot_from_2019-12-12_13-32-08

Possible fixes

https://gitlab.com/gitlab-org/gitlab/blob/49589abe9ce576ffb8bdbcc4da766d2654cbc23a/app/views/layouts/nav/sidebar/_admin.html.haml#L234

An easy and fast solution would be to change nav_link(path: 'application_settings#show') to nav_link(controller: 'application_settings', action: %i(general show)). But this issue is a part of a more general issue: #43659 (closed).

Edited Dec 12, 2019 by A. I. Oleynikov
Assignee Loading
Time tracking Loading