BACKUP and PREVIOUS_BACKUP are not respected by `backup-utility` in >= 16.6

Summary

Up to the 16.5.x versions just specifying BACKUP environment variable (eg: BACKUP=foo) was enough to make backups have not timestamped directories in @hashed, but named as foo.

Starting 16.6 and including latest 16.7.0 the BACKUP is not respected anymore. I tried to set INCREMENTAL=yes, and PREVIOUS_BACKUP=foo but it does not change anything.

How the path currently looks:

repositories/@hashed/00/32/00328ce57bbc14b33bd6695bc8eb32cdf2fb5f3a7d89ec14a42825e15d39df60/1703485746_2023_12_25_16.7.0-ee

how it looked in <= 16.5 and how it should look as per the documentation:

repositories/@hashed/00/32/00328ce57bbc14b33bd6695bc8eb32cdf2fb5f3a7d89ec14a42825e15d39df60/foo

Steps to reproduce

Create a backup with backup-utility and check the directory structure.

Example Project

What is the current bug behavior?

BACKUP environment variable is ignored and backups are created with timestamp.

What is the expected correct behavior?

BACKUP environment variable should be used.

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info


(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)
(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)
(we will only investigate if the tests are passing)

Gitlab is installed using https://gitlab.com/gitlab-org/charts/gitlab