Properly Scope Overage Members Modal to SaaS
Summary
Blocks: #388124 (closed)
While removing the FF that guards the new overage members modal it was discovered that we did not properly scope the code to SaaS. This results in SM EE instances trying to make calls to Cdot that will always fail.
Of note:
- While we will always make this request (once we remove the FF) - we handle the failure gracefully and the invite modal still works as expected by falling back to default behavior.
- This is technically only an issue once we remove the FF. EE SM instances are not currently making this request.
Scoping the customersdot proxy will be taken care of here: Scope customersdot GraphQL proxy as a SaaS feature (#439030).
Proposal
Using https://docs.gitlab.com/ee/development/ee_features.html#saas-only-feature
- Adding
overage_members_modal
feature flag toee/lib/ee/gitlab/saas.rb
following the instructions you linked to https://docs.gitlab.com/ee/development/ee_features.html#saas-only-feature. - Add
Gitlab::Saas.feature_available?
to theskip
-hook like so:skip() { return !Gitlab::Saas.feature_available? || this.isGroupInvite || !this.isVisible; },
- Removing all other instances of the
overage_members_modal
feature flag as you have done in your MR: Remove overage_members_modal feature flag (!138580 - closed), which will be taken care of with [Feature flag] Cleanup overage_members_modal (#388124 - closed).
Steps to recreate
Edited by Michael Lunøe