WebIDE: "No changes" empty state shows up in the Changes tab, despite having a new/renamed file in changes

Summary

If you add a new file, or rename an existing file, a "No changes" empty state shows up in the changes tab, whereas, there are clearly some changes that have been already added.

Steps to reproduce

  • Go to a project
  • Click "Web IDE" button. From here, there are 2 ways to test, both of which fail:
    • add new file. Do not add any content.
    • rename existing file
  • Click "Commit"

What is the current bug behavior?

The "No changes" empty state will appear, despite there being clearly some changes.

What is the expected correct behavior?

The "No changes" empty state should not appear.

Relevant logs and/or screenshots

Case new file added existing file renamed
Screenshot Screenshot_2019-12-13_at_1.24.00_AM Screenshot_2019-12-13_at_1.24.41_AM

Possible fixes

Call action breakUnusedSeal on rename and on creating a new file. It is currently called only after any changes are made to a file, or when a file is deleted. Not for new files and file renames.

Edited by Himanshu Kapoor