Show "Needs triage" instead of "DETECTED" in finding modal
Summary
"Needs triage" has been shown as label for the detected state for a vulnerability for a while already. We should also show this for findings now.
New modal
The vulnerability_finding_modal.vue simply shows the state capitalized (without translation support). This should instead show the proper translated labels "Needs triage", "Confirmed", "Dismissed", and "Resolved".
Old modal
The old modal simply shows the state (non-capitalized) (without translation support). This should instead show the proper translated labels "Needs triage", "Confirmed", "Dismissed", and "Resolved".
Implementation steps
new modal
- Use ee/vue_shared/security_reports/components/status_badge.vuecomponent inee/app/assets/javascripts/security_dashboard/components/shared/vulnerability_details_graphql/index.vue
- Update specs accordingly
- Make sure E2E tests succeeds
old modal
- Use ee/vue_shared/security_reports/components/status_badge.vuecomponent inee/app/assets/javascripts/vue_shared/security_reports/components/vulnerability_details.vue
- Update specs accordingly
- Make sure E2E tests succeeds
Verification steps
New finding modal
- go to https://gitlab.com/gitlab-examples/security/security-reports/-/pipelines/1101909537/security
- click on a finding in the needs triage state
- the finding modal should show a status badge with "Needs triage" now instead of "DETECTED"
Old finding modal
- go to gitlab-examples/security/security-reports!110 (closed)
- expand the security report widget and click on a finding that is not dismissed
- the finding modal should show a status badge with "Needs triage" instead of "Detected"
Edited  by Lorenz van Herwaarden

