Skip to content

Show "Needs triage" instead of "DETECTED" in finding modal

Summary

"Needs triage" has been shown as label for the detected state for a vulnerability for a while already. We should also show this for findings now.

New modal

The vulnerability_finding_modal.vue simply shows the state capitalized (without translation support). This should instead show the proper translated labels "Needs triage", "Confirmed", "Dismissed", and "Resolved".

Screenshot_2023-12-06_at_08.48.36

Old modal

The old modal simply shows the state (non-capitalized) (without translation support). This should instead show the proper translated labels "Needs triage", "Confirmed", "Dismissed", and "Resolved".

Screenshot_2023-12-06_at_08.53.52

Implementation steps

new modal

  1. Use ee/vue_shared/security_reports/components/status_badge.vue component in ee/app/assets/javascripts/security_dashboard/components/shared/vulnerability_details_graphql/index.vue
  2. Update specs accordingly
  3. Make sure E2E tests succeeds

old modal

  1. Use ee/vue_shared/security_reports/components/status_badge.vue component in ee/app/assets/javascripts/vue_shared/security_reports/components/vulnerability_details.vue
  2. Update specs accordingly
  3. Make sure E2E tests succeeds

Verification steps

New finding modal

  1. go to https://gitlab.com/gitlab-examples/security/security-reports/-/pipelines/1101909537/security
  2. click on a finding in the needs triage state
  3. the finding modal should show a status badge with "Needs triage" now instead of "DETECTED"

Old finding modal

  1. go to gitlab-examples/security/security-reports!110 (closed)
  2. expand the security report widget and click on a finding that is not dismissed
  3. the finding modal should show a status badge with "Needs triage" instead of "Detected"
Edited by Lorenz van Herwaarden