Follow-up from "Add increasing wait time between phone verification code sends"
The following discussion from !137850 (merged) should be addressed:
-
@dstull started a discussion: issue (non-blocking):
I see this method only being used in
ee
, but defined here ince
. So I started analyzing thePhoneNumberValidation
code to see if it was violating separation of code guidelines we have in https://docs.gitlab.com/ee/development/ee_features.html.I then looked for any code that used phone validation outside of
ee
and only found Admin::AbuseReportDetailsEntity so far that referenced thePhoneNumberValidation
model fromce
.I think the origin of this comes from outside via Users/IdentityVerificationController.
I believe we should have a follow-up here to explore things about IdentityVerification and PhoneNumberValidation:
- Is this code guarded by a license feature?
- Is this code only to run on SaaS ever? If so we should explore moving all to
ee
as well and following this guideline for implementation. - Is there a reason Admin::AbuseReportDetailsEntity is defined in
ce
or could it merely followee
features guidelines to move it toee
?
-
Move EE-only spec (those that use Gitlab.ee?
) fromspec/serializers/admin/abuse_report_details_entity_spec.rb
toee/spec/serializers/ee/admin/abuse_report_details_entity_spec.rb
(implemented in !141347 (merged)) -
Move user.verification_state.phone
exposure fromapp/serializers/admin/abuse_report_details_entity.rb
toee/app/serializers/ee/admin/abuse_report_details_entity.rb
(implemented in !143789 (merged)) -
Move user.phone_number
exposure fromapp/serializers/admin/abuse_report_details_entity.rb
toee/app/serializers/ee/admin/abuse_report_details_entity.rb