Show dismissal reason in pipeline security tab
With pipeline_security_dashboard_graphql
enabled, the pipeline security tab shows the new vulnerability list table (also shown on vulnerability report page). This supports showing the dismissal reason of a finding (or vulnerability) in a badge. To support this we need to fetch the dismissalReason
of the findings too.
Implementation plan
- Add
dismissalReason
field inee/app/assets/javascripts/security_dashboard/graphql/queries/pipeline_findings.query.graphql
- Update related frontend specs
Verification steps
- go to https://gitlab.com/gitlab-org/govern/threat-insights-demos/verification-projects/verification-for-433336/-/pipelines/1096994343/security?state=DETECTED,DISMISSED
- verify that the dismissed finding shows a badge for the "Mitigating control" dismissal reason
- you can click on the other finding (the one in Needs triage) and in the finding modal dismiss with a reason
- After confirm dismissal you'll need to refresh the page (refetching will be implemented with #433509 (closed))
- There should be 2 dismissed findings with their dismissal reason badges
Edited by Lorenz van Herwaarden