Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,105
    • Issues 44,105
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,401
    • Merge requests 1,401
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #4326
Closed
Open
Created Dec 13, 2017 by Victor Wu@victorwuContributor

Send one email notification for one published code review

Merge request reviews, introduced in GitLab 11.4, allow a reviewer to leave multiple comments in one go, but this still sends one email for every comment added. This creates a large number of email notifications that likely reference each other because it was been submitted as a singular review.

GitLab should only send one email notification for one published code review.

Proposal

Update the GitLab application to only send one email when a review is published

Designs

HTML email

mockup

Text email

Merge request https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/915 was reviewed by Yorick Peterse.

--

Yorick Peterse commented on a discussion on app/assets/javascripts/dispatcher.js (https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/915#note_2342342342)

> - code
> + code
> + code

@rdavila Could you please review this one line backend change?

--

Yorick Peterse started a new discussion on app/assets/javascripts/dispatcher.js (https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/915#note_2342342342)

> - code
> + code
> + code

@rdavila Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. 

Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

--

You're receiving this email because of your account on http://gitlab.com. If you'd like to receive fewer emails, you can unsubscribe (https://gitlab.com/sent_notifications/REDACTED/unsubscribe) from this thread or adjust your notification settings.
  • The diff should include a maximum of 3 lines (if available) i.e. 2 lines before the line where the comment has been made.
Original proposal ### Designs

Email

The info included in a discussion:

  • Who comments on a discussion on which file (e.g. Yorick Peterse commented on a discussion on app/assets/javascripts/dispatcher.js)
  • 3 lines of diff
  • Reviewer's comment
  • The resolved / unresolved states
  • A link to view the discussion on GitLab.com

mr-email-published-review

Resovled / unresolved states

Yorick resolved this discussion Yorick unresolved this discussion Discussion remains resolved Discussion remains unresolved
state-discussion--resolved-by-a-user state-discussion--unresolved-by-a-user state-discussion--remains-resolved state-discussion--remains-unresolved

Links / references

Edited Nov 20, 2018 by Jeethu Karthik
Assignee
Assign to
Time tracking