Next

Merge request reviews, introduced in GitLab 11.4, allow a reviewer to leave multiple comments in one go, but this still sends one email for every comment added. This creates a large number of email notifications that likely reference each other because it was been submitted as a singular review.

GitLab should only send one email notification for one published code review.

Proposal

Update the GitLab application to only send one email when a review is published

Designs

HTML email

Text email

Merge request https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/915 was reviewed by Yorick Peterse.

--

Yorick Peterse commented on a discussion on app/assets/javascripts/dispatcher.js (https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/915#note_2342342342)

> - code
> + code
> + code

@rdavila Could you please review this one line backend change?

--

Yorick Peterse started a new discussion on app/assets/javascripts/dispatcher.js (https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/915#note_2342342342)

> - code
> + code
> + code

@rdavila Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. 

Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

--

You're receiving this email because of your account on http://gitlab.com. If you'd like to receive fewer emails, you can unsubscribe (https://gitlab.com/sent_notifications/REDACTED/unsubscribe) from this thread or adjust your notification settings.

• The diff should include a maximum of 3 lines (if available) i.e. 2 lines before the line where the comment has been made.

Original proposal

### Designs

Email

The info included in a discussion:

• Who comments on a discussion on which file (e.g. Yorick Peterse commented on a discussion on app/assets/javascripts/dispatcher.js)
• 3 lines of diff
• Reviewer's comment
• The resolved / unresolved states
• A link to view the discussion on GitLab.com

Resovled / unresolved states

Yorick resolved this discussion	Yorick unresolved this discussion	Discussion remains resolved	Discussion remains unresolved

Links / references