Comments search has a high number of database calls
Summary
There is a high number of calls to the database when loading comments search results.
Steps to reproduce
- enable the performance bar
- perform a global comments search: https://gitlab.com/search?scope=notes&search=test
- for the search I performed, there were 217 postgres calls
What is the current bug behavior?
There are some (undetected) N+1 calls for comments search results
Possible fixes
- Web UI preloads from
SearchControllerare usingwith_web_entity_associationsfrom the note model - note view is rendered using HAML:
app/views/search/results/_note.html.haml - N+1 specs are likely missing data setup (for whatever data is causing the excessive queries):
