[Bug] Pipeline Schedule UI: Inputs not resizeable
Summary
Inputs in pipeline schedule UI are not resizeable, though they seem to be.
This can be observed when creating a new scheduled pipeline or editing an already existing one.
Steps to reproduce
- Open pipeline schedules page
- Create new schedule
- Add variable and try to resize value input field
Example Project
What is the current bug behavior?
Inputs do not resize.
What is the expected correct behavior?
Should be resizeable like native textarea.
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
Version: v16.5.1-ee (For installations with omnibus-gitlab package run and paste the output of: \`sudo gitlab-rake gitlab:env:info\`) (For installations from source run and paste the output of: \`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production\`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:check SANITIZE=true`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`) (we will only investigate if the tests are passing)
Possible fixes
As you can see in the attached screenshot, on resize the height is changed in the elements style
attribute. However, that style is overruled by the !important
styles for the gl-h-7!
class.
Implementation Guide
- In https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/ci/pipeline_schedules/components/pipeline_schedules_form.vue#L410, change the class from
gl-h-7!
togl-h-7
- Add the
gl-h-7
class to the following line https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/ci/pipeline_schedules/components/pipeline_schedules_form.vue#L440 - Modify the following class attribute to preserve the
$options.formElementClasses
and include thegl-h-7
class. A computed prop is recommended https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/ci/pipeline_schedules/components/pipeline_schedules_form.vue#L392
Edited by Veethika Mishra