Ignore max_workspaces and max_workspaces_per_user fields
MR: Ignore max_workspaces and max_workspaces_per_us... (!137090 - merged)
Ignore max_workspaces and max_workspaces_per_user fields
-
@cwoolley-gitlab started a discussion: (+2 comments) @a_akgun Please see this comment: #426512 (comment 1617748504)
In that thread, we decided (based upon the discussion during the engineering sync) that
max_was probably not the best name for this field:max_*is probably not the right naming convention for these settings. We can instead useworkspaces_per_user_quotaandworkspaces_quotainstead as "exceeding a quota" is perhaps more intuitive way to express a user having more than the allowed no. workspaces vs "exceeding a maximum".We unfortunately didn't also update the title of the associated issues to reflect this decision, and I didn't remember in time to catch it before this MR got merged.
However, I still think naming things appropriately is important, so my vote is to go ahead and change the name of the fields before we start writing more code around them.