Follow-up from "Ensure repository set to writable after moving storage"
The following discussion from !136318 (merged) should be addressed:
-
@vyaklushin started a discussion: (+1 comment)
Note I've just realized that this execution order has (and had before) a tiny flaw.
finish_replication!
call unblocks git pushes. If somebody pushes something in between offinish_replication!
and transaction after, then the new pushed code might end up in the old repository.I wonder if we should reverse these two blocks.
repository_storage_move.transaction do track_repository(destination_storage_name) end repository_storage_move.finish_replication!
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Joe Woodward changed milestone to %16.6
changed milestone to %16.6
- Joe Woodward assigned to @jwoodwardgl
assigned to @jwoodwardgl
- Joe Woodward added Category:Source Code Management WGDisasterRecovery backend bugavailability devopscreate groupsource code sectiondev typebug + 1 deleted label
added Category:Source Code Management WGDisasterRecovery backend bugavailability devopscreate groupsource code sectiondev typebug + 1 deleted label
- 🤖 GitLab Bot 🤖 changed milestone to %16.7
changed milestone to %16.7
- 🤖 GitLab Bot 🤖 added missed:16.6 label
added missed:16.6 label
- Developer
@jwoodwardgl I'm assuming you want to work on this outside deliverables, so setting to a weight of 0.
1 - Sean Carroll set weight to 0
set weight to 0
- Joe Woodward removed 1 deleted label
removed 1 deleted label
- Sean Carroll added workflowready for development label
added workflowready for development label
- Sean Carroll added priority2 severity2 labels
- Maintainer
severity2 with bugavailability can only have priority1
Please see the Availability prioritization guidelines for more detail.
This message was generated automatically. You're welcome to improve it.
- 🤖 GitLab Bot 🤖 added priority1 label and removed priority2 label
- Sean Carroll added maintenancerefactor label
added maintenancerefactor label
- 🤖 GitLab Bot 🤖 added typemaintenance label and removed bugavailability typebug labels
added typemaintenance label and removed bugavailability typebug labels
- Sean Carroll added priority2 label and removed priority1 label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15170 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15170 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15265 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15265 (closed)
- Developer
Moving to %16.8
- Sean Carroll changed milestone to %16.8
changed milestone to %16.8
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15385 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15385 (closed)
- Developer
Moving to %Next 1-3 releases
- Sean Carroll changed milestone to %Next 1-3 releases
changed milestone to %Next 1-3 releases
- Maintainer
@vyaklushin @jwoodwardgl according to the description, it's a tiny flaw, can we decrease it in priority/severity or severity2 is fine?
Collapse replies - Maintainer
@igor.drozdov feel free to decrease it to severity3. This problem is an edge case that existed for while. It's not that severe.
- Maintainer
@vyaklushin great, thanks!
/cc @sean_carroll
1
- Sean Carroll changed weight to 1 from 0
changed weight to 1 from 0
- Marie-Christine Babin changed milestone to %16.11
changed milestone to %16.11
- Marie-Christine Babin added planningto-do label
added planningto-do label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#16627 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16627 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#16727 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16727 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#16811 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16811 (closed)
- André Luís changed milestone to %17.0
changed milestone to %17.0
- André Luís removed planningto-do label
removed planningto-do label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#16917 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16917 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#16996 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16996 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17189 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17189 (closed)
- Marie-Christine Babin changed milestone to %17.2
changed milestone to %17.2
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17269 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17269 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17344 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17344 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17444 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17444 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17611 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17611 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17714 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17714 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17795 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17795 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17901 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17901 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18066 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18066 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18165 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18165 (closed)
- André Luís added Deliverable label
added Deliverable label
- 🤖 GitLab Bot 🤖 added missed-deliverable label
added missed-deliverable label
- Maintainer
Setting health status to
needs attention
as this item slipped the previous milestone.Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to needs attention
changed health status to needs attention
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18249 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18249 (closed)
- Developer
@jwoodwardgl this is assigned to you as a Deliverable
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18358 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18358 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18438 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18438 (closed)
- Author Maintainer
Staring work on this. Should be a quick win
- Joe Woodward added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Joe Woodward added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Joe Woodward added workflowcomplete label and removed workflowin review label
added workflowcomplete label and removed workflowin review label
- Joe Woodward closed
closed
- Joe Woodward removed workflowcomplete label
removed workflowcomplete label
- Joe Woodward added workflowcomplete label
added workflowcomplete label