Remove invalid values from Value Stream project_ids_filter setting
On Analytics::CycleAnalytics::ValueStreamSetting
it is possible to persist an array of projects ids to filter the data on group level value streams.
The values for the mentioned projects filter are stored at project_ids_filter
field, we should remove any entries from projects that do not belong to the group hierarchy when calling this method.
The following discussion from !136252 (merged) should be addressed:
-
@felipe_artur started a discussion: (+3 comments) While writing this spec I realized that we should probably have a follow-up to add another validation to
ValueStreams::Setting#project_ids_filter
checking if it belongs to a group value stream.It does not make much sense to have
project_ids_filter
on project-level Value Streams. WDYT?