Experiment features should not depend on AI settings
Currently, experiment_features_enabled
field in NamespaceSetting
can only be set to true
if ai_settings_allowed? || ai_assist_ui_enabled?
.
However, experiment features should be generic and not depend on ai settings.
Technical Proposal
- In
ee/app/controllers/ee/groups_controller.rb
- if ai_settings_allowed? || ai_assist_ui_enabled?
+ if experiment_settings_allowed?
params_ee.push(:experiment_features_enabled)
end
- In
ee/app/models/ee/namespace_setting.rb
def experiment_features_allowed
return unless experiment_features_enabled_changed?
- return if ai_settings_allowed?
+ return if experiment_settings_allowed?
errors.add(:experiment_features_enabled, _("Experiment features' settings not allowed."))
end
- Update the relevant specs.
Acceptance criteria
- You should be able to toggle Product Analytics toggle in group settings page even when
ai_settings_allowed
isfalse
.