Follow-up from "Fix user migration for context on trial redesign experiment"
The following discussion from !135635 (merged) should be addressed:
-
@dstull started a discussion: (+6 comments) note (non-blocking):
Looking into this more in https://gitlab.com/gitlab-org/ruby/gems/gitlab-experiment#cookies-and-the-actor-keyword, I don't think this solves the issue.
There is also something going on where this one is
control
even though the first run should've set it tocandidate
...The only way I've found to get this to work(show candidate) is to define the behavior in a class like
ee/app/experiments/free_trial_registration_redesign_experiment.rb
, but even then thekey
value doesn't match the firstkey
value, which tells me the signature is off and not correctly seeing the migrated cookie...even if I supply
request: request
to each case.This will require more thought...putting back into draft until myself or someone else can look into it more and added latest commit for the trail I was going down.
Plan
-
Add GLEX How to wiki and link - !135892 (merged)