[SPIKE] Align the actionable items of the SAST inline findings Drawer with the Security MR Widget
The main objective of this spike is to understand the feasibility and the necessary steps to align the actionable items of the SAST inline findings Drawer with the actionable Items on the Security MR Widget.
Security MR Widget Modal | SAST Inline Findings Drawer |
---|---|
![]() |
![]() |
related Design Issue: #415112 (closed)
Existing Functionality:
Demo Video |
---|
2023-10-31_10-15-50 |
Demo Project: jannik_lehmann/sast-inline-findings-example!1 (merged)
- "Dismiss Vulnerability"-> Set Status of finding to Dismissed reverts to undo Dismiss when Vuln is already dismissed
- "Add Comment and Dismiss"-> Set Status of finding to Dismissed & opens text field to leave comment. This button reverts to undo Dismiss when Vuln is already dismissed
- The vulnerability modal shows the issue or displays button to create one if no Issue exists.
- Displays existing comments
For the MR Widget the logic is currently implemented in modal.vue and modal_footer.vue
Open Questions:
- Are there any restrictions when adding the features to a drawer instead of a modal? UX
- How should these features interact with the drawer (mainly closing & opening)? UX
- Client/Server Communication: What endpoints is the modal using? Can we reuse them on the drawer? Do we have all the data we need to provide it on the request? backend frontend
- Can we share the existing UI-components for the actionable items? frontend
Completion Criteria:
- Ensure that the entire UX workflow is outlined in the Design Issue. This should address any potential user journey pain points, expected user interactions, and offer clarity on how the feature would be perceived by Users.
- Conduct a thorough technical exploration of the necessary changes.
- Develop a clear implementation plan that breaks the process down process into actionable tasks.
- Create detailed issues for each of these tasks
Edited by Jannik Lehmann