Follow-up from "Update Redis::SharedState to be Cluster compatible"
The following discussion from !133790 (merged) should be addressed:
-
@allison.browne started a discussion: (+1 comment) I was surprised to find this does not have a unit test but It looks like it gets covered via the testing of
Ci::BuildTraceChunks::Redis
.It's still uncovered in places because
Ci::BuildTraceChunks::Redis
which inherits fromRedisBase
is tested butCi::BuildTraceChunks::RedisTraceChunks
is not tested.It seems worth creating another issue to used some
shared_exampes
and ensure both are covered. Or what do you think about doing that here?
Edited by Sylvester Chin