Bug: Diff "Files changed" count off for MR targeting non-default branch

Description

Noticed on .com in gitlab-web-ide!254 (merged)

gl_diff_count_bug

  • Branch ps-update-eslint-rules contains a bunch of eslint fixes (129 files changed)
  • Branch ps-update-eslint-rules-2 contains a small follow-up update (6 files changed on top of ps-update-eslint-rules)
  • The MR for ps-update-eslint-rules-2 points to ps-update-eslint-rules
  • The MR for ps-update-eslint-rules-2 shows 131 files changed on first load. After clicking diff tab, it shows 6 files. When scrolling down and triggering the sticky header, it shows 131 files.

UPDATE: It turns out that gitlab-web-ide!254 (merged) was based on an outdated commit from gitlab-web-ide!253 (merged), so the MR showed 2 commits whose sum of changes were 131 files, but the merge changes were only 6 files. Now gitlab-web-ide!254 (merged) is only showing 1 commit and 6 files changed from the start.

Edited by 🤖 GitLab Bot 🤖