Group milestones are missing from search API

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Summary

When using the /api/v4/search?scope=milestones&search= I'm getting back all milestones except the ones that are made at the group level.

Current State

  • Advanced search (Elasticsearch) supports instance and group searches for milestones
  • Only project-level milestones are currently indexed in Elasticsearch
  • Group-level milestones (milestones with group_id but no project_id) are not indexed
  • This occurs because the use_elasticsearch? method in Elastic::ApplicationVersionedSearch only checks self.project&.use_elasticsearch?
  • For group milestones where project is nil, this always returns nil, preventing them from being indexed

Impact

  • Group-level milestones cannot be found via advanced search at instance or group level
  • Search results are incomplete and inconsistent
  • Users searching for milestones at group or instance level miss important group-level milestones

Steps to reproduce

  1. Create a group milestone
  2. Search for it.

What is the current bug behavior?

Group Milestones are not showing up in search results.

What is the expected correct behavior?

Group Milestones also show up in search results.

Edited by Terri Chu