Feedback: rubocop inline disable suggesting
What?
Please leave feedback on the danger conversation starter for disabling
Docs
Refs https://docs.gitlab.com/ee/development/rubocop_development_guide.html
By default, we should not disable a RuboCop rule inline, because it negates agreed-upon code standards that the rule is attempting to apply to the codebase.
If you must use inline disable, provide the reason on the MR and ensure the reviewers agree before merging.
Statistics
How many RuleCop rules disables were flagged by Danger and how many were merged, closed, or still open?
RuboCop rules disables reverted: 9
List of RuboCop rules disables which got merged:
CodeReuse/ActiveRecord: 5
RSpec/DuplicateSpecLocation: 4
Lint/InterpolationCheck: 2
Metrics/AbcSize: 2
QA/ElementWithPattern: 2
Scalability/IdempotentWorker: 2
List of RuboCop rules disables which are still open:
Migration/PreventIndexCreation: 17
CodeReuse/ActiveRecord: 11
Layout/LineLength: 7
Cop/ExperimentsTestCoverage: 4
RSpec/FactoryBot/AvoidCreate: 4
Capybara/TestidFinders: 2
Gitlab/AvoidGitlabInstanceChecks: 2
GitlabSecurity/PublicSend: 2
Graphql/AuthorizeTypes: 2
Cop/ActiveRecordDependent: 1
Gemfile/MissingFeatureCategory: 1
Gitlab/ModuleWithInstanceVariables: 1
Metrics/AbcSize: 1
Metrics/PerceivedComplexity: 1
RSpec/ExpectInHook: 1
Rails/LexicallyScopedActionFilter: 1
Scalability/CronWorkerContext: 1
Style/SignalException: 1
Done by this script. Last update 2023-10-17.
Edited by Peter Leitzen