Skip to content

Analytics Instrumentation review did not get triggered for ::Gitlab::Tracking.event

Problem

https://gitlab.com/gitlab-org/gitlab/blob/master/tooling/danger/project_helper.rb#L134 should lead to analytics instrumentation review being triggered if someone adds a call to Gitlab::Tracking.event in their code. This did not happen in !133589 (merged)

Desired Outcome

We understand why the bot did not trigger the review in !133589 (merged) and have a fix in place that would lead to review being triggered the next time a similar MR is created.

Proposed Solution

TBD

How to verify

Opening up an MR with a call to Gitlab::Tracking.event like it is used in !133589 (merged) and review is correctly triggered