Blocked users still show up in review requests when assigned as a group
Summary
If you have a merge request template that does /assign_reviewer @foo_group
, it will also add blocked accounts as reviewers.
Our suggestion is to not assign blocked accounts as reviewers, as they cannot review anyways.
Steps to reproduce
- Create a group
- Assign an user
- Block that user
- Create a Merge Request and
/assign_reviewer @groupname
- Blocked user will be part of the reviewers.
Example Project
What is the current bug behavior?
The blocked user is part of the reviewers
What is the expected correct behavior?
The blocked user should not be part of reviewers.
Results of GitLab environment info
Self-hosted 16.4, but happens on any GitLab instance
Possible fixes
1: Either don't show blocked users as reviewers
2: Don't assign blocked users as reviewers
Edited by Jos Ahrens