Spike: Follow-up from "Replace different_project? method with instance variable"
The app/controllers/concerns/creates_commit.rb
makes heavy use of instance variables, and those variables are then referred to directly in classes using the concerns
this creates some dependency and ordering complexity, and could likely be refactored to use a new object(s) instead.
It was out of scope for the MR where the discussion began, as some work is needed to research and experiment to find an implementation that doesn't break any of the existing dependencies
The following discussion from !131412 (merged) should be addressed:
-
@kerrizor started a discussion: (+11 comments) @abitrolly I'm not opposed to this change per se, but having to trace the logic of what
@different_project
means in this case feels a bit like we're trading one form of obfuscation for another. Can you think of a better ivar name here as well?Running a full pipeline.. let's get a second
👀 from another reviewer as well.