Percentage-based Feature Flags should return the same value within the same request
See gitlab-com/gl-infra/production#16366 (comment 1559481844)
We could probably use SafeRequestStore
Proposal
- We ban using percentage of time => #425428 (closed)
- We introduce
request
based actor. This ensures that for a X% percentage of actors rollout, theFeature.enabled?(:key, request)
will always return the same value within the same request. - Migrate
optimize_routable
FF to use current request actor -
We add ability in chatops forJust use https://docs.gitlab.com/ee/development/feature_flags/controls.html#percentage-based-actor-selection--requests N
where N can be0
to100
.
Follow-up issues
Edited by Thong Kuah