Force include all resources logic for workspaces
MR: Force include all resources logic for workspaces (!132507 - merged)
Discussions
Discussions in the previous MR Force full reconciliation logic for workspaces (!131374 - closed)
- We will rename the boolean field on the
workspaces
record fromforce_full_reconciliation
toforce_include_all_resources
. - Every other place this field is used in this MR will remain unchanged, other than renaming it
- And we we will still need to add it to
WorkspacesToBeReturnedFinder.generate_workspaces_to_be_returned_query
to modify the query to include workspaces where it istrue
in theworkspaces_to_be_returned
array). - We will rename the argument passed into
DesiredConfigGenerator.generate_desired_config
frominclude_secrets
toinclude_all_resources
The reasoning behind these changes are:
- It eliminates the naming confusion described in !131887 (comment 1565374059), where we are saying are doing a "force full reconciliation" even in the case of a "PARTIAL", not "FULL" reconciliation.
- It makes the field name and argument name describe exactly what is happening, which is that all resources are being forced to be included.
Description
Add logic in Rails to send full reconciliation for the workspace if force_full_reconciliation
is set to true
. It would not matter whether the update type from agent is partial/full. Once data is sent to agent, update force_full_reconciliation
to false
for the workspace.
Acceptance criteria
[ ] The logic is implemented
Edited by Chad Woolley