[FEATURE REQUEST] Ability to REJECT/DECLINE a MR Request

Proposal

As an Engineer, I would like the ability to Reject an MR being proposed so that I can provide guidance for the engineer submitting it to fix specific issues, be notified about the issue and can re-submit the MR without having to close it first. It also allows me, the code reviewer, to know when the changes have been submitted and know (when the original author) re-submits the MR for approval again that we can re-test.

Additionally, I'd like to point out that there is nothing "unfriendly" about "Reject" or "Denied". Its a very upfront, and honest take that the MR being requested for merge is not satisfactory "yet" for reasons (that can be defined by teams: didn't pass code review, doesn't have unit testing, etc.) but still has the proper potential of being Accepted once specific criteria is met. Putting in the "feelings" of engineers into this is a step outside of the very boundaries that are necessary to make leadership decisions for projects.

As a matter of a fact, "Reject" is already a term that's applied in gitlab for rejecting deployments (see documentation).

A "Closed" status for a ticket has been historically reserved for one of the following reasons:

• It is permanently rejected and will not be addressed/allowed to be merged in
• It has been decided to no longer been needed so it was closed (due to a duplicate solution)
• It was merged in and the change has made it to the main repo, so the ticket has been closed

Rejected is a great way for engineering teams to say "I like the MR, but we cannot merge this in. Fix the problems and then when you are ready, mark it as "Ready for Review" so that we can conduct another review.

Its a feature that I'm just completely surprised wasn't already in place. Its also something that is baked into github and has been very useful for engineering teams to rely on.

Please consider adding this much needed feature!

See related issue topic

Category:Groups & Projects Category:Organization GitLab Free GitLab Premium GitLab Ultimate typefeature featureaddition