Cleanup groups_dropdown_filter from productivity analytics
It was identified during the MR Migrates legacy dropdown for groups_dropdown_fi... (!130325 - merged) • Artur Fedorov • 16.4 that the groups_dropdown_filter and some related functionality could be removed.
Original comment
> However, seeing that the `hide_group_drop_down` is hard-coded to `true` in `ee/app/views/groups/analytics/productivity_analytics/show.html.haml` and that that was done 4 years ago, I'm wondering if this dropdown could simply be removed because it's never shown.I also don't see any other #js-productivity-analytics
where the productivity_analytics app could hook onto, like e.g. a productivity analytics page for the instance (where a group filter could make sense). If the productivity analytics is only shown on the group-level, I don't think a group dropdown makes sense. But I could be mistaken.
Implementation steps
- completely remove
ee/app/assets/javascripts/analytics/shared/components/groups_dropdown_filter.vue
and its spec - remove the use of groups_dropdown_filter,
onGroupSelected
method,groupsQueryParams
option, andhideGroupDropDown
prop inee/app/assets/javascripts/analytics/productivity_analytics/components/filter_dropdowns.vue
and adapt the spec - do not extract
hideGroupDropDown
from the dataset and do not passhideGroupDropdown
to FilterDropdowns inee/app/assets/javascripts/analytics/productivity_analytics/index.js
- remove hardcoded
hide_group_drop_down
fromee/app/views/groups/analytics/productivity_analytics/show.html.haml