Skip to content

Address cyclical dependency of `email_additional_text` feature check with ApplicationSetting

Problem

The feature email_additional_text is marked as incompatible with Usage Ping because the License.feature_available? has a cyclical dependency with ApplicationSetting and a test will fail if we try to move it to Registration Features (a.k.a Usage Ping features).

There is plan to move this feature to Registration Features but currently this feature is blocked by the cyclical dependency.

Reproduction steps

Proposal

Refactor the code (possibly from ApplicationSetting) not to rely so early in the app setup / startup on License.feature_available? for the given feature.

Once the refactoring solves the cyclical dependency, remove the feature from FEATURES_NOT_SUPPORTING_USAGE_PING list.

Edited by Heinrich Lee Yu