Increase max sources limit for Cobertura files for test coverage visualization
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Proposal
In the Test coverage visualization docs, we document:
A limit of 100
<source>nodes for Cobertura format XML files applies.
I believe that is the MAX_SOURCES limit that we see set to 100 in lib/gitlab/ci/parsers/coverage/sax_document.rb.
A few years ago, we noted an assumption that Cobertura files with more than 100 source nodes would be an edge case.
This issue proposes to increase the limit for the total number of <source> nodes that can be included in Cobertura format XML files. This is being opened on behalf of a Premium customer who has Cobertura files that far exceed the 100 source nodes limit. They have in excess of 7,000 nodes. Having the limit set to a number like 10,000 or higher would help.
A sanitized copy of their Cobertura file is attached: cobertura-example.xml
- We completed the work to Implement SAX::Parser for cobertura parser after the 100
<source>node limit was set. Do the performance improvements we expected permit us to increase this limit?