500 when viewing tags in repo that has signed commits
Summary
Our customer is encountering a 500 viewing tags in a repository that contains signed commits. They're seeing it on 16.1.3-EE in production and also 16.2.3-EE and 15.9.8-CE.
This was reported in https://gitlab.zendesk.com/agent/tickets/438815 and it's reproducible on gitlab.com.
Steps to reproduce
Create a new project using Repo by URL and add https://github.com/kubernetes/ingress-nginx.git (we use this repo as it contains signed commits).
Example Project
https://gitlab.com/amulvany/ingress-nginx
What is the current bug behavior?
Error 500 when clicking through "Code -> Tags"
What is the expected correct behavior?
Should be possible to view tags
Relevant logs and/or screenshots
==> /var/log/gitlab/gitlab-rails/production.log <==
ActionView::Template::Error (undefined method `revoked?' for nil:NilClass):
1: .gpg-popover-certificate-details
2: %strong= _('Certificate Subject')
3: - if signature.x509_certificate.revoked?
4: %strong.cred= _('(revoked)')
5: %ul
6: - x509_subject(signature.x509_certificate.subject, ["CN", "O"]).map do |key, value|
app/views/projects/commit/x509/_certificate_details.html.haml:3
app/views/projects/commit/_signature_badge.html.haml:18
app/views/projects/commit/_signature_badge.html.haml:16
app/views/projects/commit/x509/_unverified_signature_badge.html.haml:6
app/views/projects/commit/_signature.html.haml:3
app/views/projects/tags/_tag.html.haml:30
app/views/projects/tags/index.html.haml:25