Follow-up from "Changed failed pipeline jobs card border to hover and text to hide" - Improve specs
The following discussion from !127921 (merged) should be addressed:
-
@pslaughter started a discussion: suggestion (non-blocking): It's worth moving this
gl-border-white gl-hover-border-gray-100
into a test constant to emphasize and solidify the relationship between the.not.toContain
and.toContain
test.When these values change, only the
.toContain
test will fail, so we risk the.not.toContain
never being updated and becoming a useless test.Not a big deal. Just something to keep in mind.