Fix `Environment#stop_with_actions!` inconsistent behavior between Ci::Build and Ci::Bridge
Problem
Currently, there is an inconsistency on Environment#stop_with_actions!
method that:
- If a stop action is
Ci::Build
and not playable (e.g. already executed and transitioned tosuccess
status), the job is retried. - If a stop action is
Ci::Bridge
and not playable (e.g. already executed and transitioned tosuccess
status), the job is ignored.
This inconsistency could confuse users.
Proposal
Either
-
Environment#stop_with_actions!
should not retry at all if it's not playable. OR -
Environment#stop_with_actions!
should always retry if it's not playable.
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Shinya Maeda marked this issue as related to #369061 (closed)
marked this issue as related to #369061 (closed)
- Shinya Maeda added groupenvironments maintenancerefactor labels
added groupenvironments maintenancerefactor labels
- 🤖 GitLab Bot 🤖 added typemaintenance label
added typemaintenance label
- 🤖 GitLab Bot 🤖 added devopsdeploy sectioncd labels
added devopsdeploy sectioncd labels
- Shinya Maeda changed title from Regulate
Environment#stop_with_actions!
behavior between Ci::Build and Ci::Bridge to FixEnvironment#stop_with_actions!
inconsistent behavior between Ci::Build and Ci::Bridgechanged title from Regulate
Environment#stop_with_actions!
behavior between Ci::Build and Ci::Bridge to FixEnvironment#stop_with_actions!
inconsistent behavior between Ci::Build and Ci::Bridge - Hunter Stewart mentioned in issue hustewart/planning-and-growth#70
mentioned in issue hustewart/planning-and-growth#70
- Shinya Maeda added to epic &8483 (closed)
added to epic &8483 (closed)
- Furkan Ayhan mentioned in merge request !128192 (merged)
mentioned in merge request !128192 (merged)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13601 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13601 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13698 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13698 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13762 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13762 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13854 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13854 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13975 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13975 (closed)
- Shinya Maeda added workflowready for development label
added workflowready for development label
- Shinya Maeda set weight to 1
set weight to 1
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14072 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14072 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14140 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14140 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14235 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14235 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14347 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14347 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14442 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14442 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14510 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14510 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14607 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14607 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14672 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14672 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14791 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14791 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14886 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14886 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14957 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14957 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15053 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15053 (closed)
- Viktor Nagy (GitLab) added workflowplanning breakdown label and removed workflowready for development label
added workflowplanning breakdown label and removed workflowready for development label
- Viktor Nagy (GitLab) added workflowscheduling label and removed workflowplanning breakdown label
added workflowscheduling label and removed workflowplanning breakdown label