Improve naming of filter labels in dora_visualization.vue
Context
The following discussion from !127451 (merged) should be addressed:
-
@leipert started a discussion: (+4 comments) Suggestion/Question: It is a little confusing to have
rawFilterLabels
coming from the data PROPdata.filter_labels
and to havefilterLabels
which are coming from Apollo. Looking at this the first time, it is quite unclear how they interact with each other and it might even be a subtle source for bugs.- Do we need them both?
- If we need them both, could we make clear why and potentially rename them to make them more distinguishable?
Oh, and unless this is an easy fix, we are definitely in the follow-up territory with this one.
Proposal
Within dora_visualization.vue:
- Rename
rawFilterLabels
tofilterLabelsQuery
- Rename
filterLabels
tofilterLabelsResults
Edited by Alex Pennells