CiConfiguration::BaseCreateService should use un-related error class
Overview
As a follow-up to !125437 (merged), it was decided to replace exceptions of type Gitlab::Graphql::Errors::MutationError
that are present in Security::CiConfiguration::BaseCreateService
to use ServiceResponse.error
method as outlined below.
This is because the class is not solely used in a graphql
context. Please see this discussion for more information.
Implementation Plan
The following discussion from !125437 (merged) should be addressed:
-
@tkuah started a discussion: (+2 comments) Yeah, let's switch to using
ServiceResponse.error
as a follow-up.
Edited by Ahmed Hemdan