test-prof: Remove `factory_default: :keep` metatag

changed milestone to %16.3

added backend maintenancerefactor test typemaintenance labels

test-prof's doc says:

Defaults created within before_all and let_it_be are not reset after each example, but only at the end of the corresponding example group.

That's a good observation! Removing factory_default: :keep creates more factories though (176 instead of 98). It seems that the factory definitions are actually not reset but the association mapping (read: the "factory defaults") are. So, create(:issue), does not use the previously created project association anymore. I might be wrong here though. /cc @igor.drozdov

Perhaps that's why factory_default: :keep is needed.

I also noticed that we are require'ing FactoryDefault without using its recipe test_prof/recipes/rspec/factory_default. It did not make a change but I'd like to investigate whether our docs or test-prof's needs an update

Note, looking at https://github.com/test-prof/test-prof/blob/master/spec/integrations/fixtures/rspec/factory_default_let_it_be_fixture.rb it seems the associations should be reused though...

Mh, after some testing and removing factory_default: :keep + TestProf::FactoryDefault.reset in spec/support/factory_default.rb the factory default still works as before

So, perhaps the test-prof's docs are right after all and factory_default: :keep is not needed because let_it_be + create_default already works we want it to work?

mentioned in merge request !126473 (merged)

@splattael, Please add a group or category label to identify issue ownership.

You can refer to the Features by Group handbook page for guidance.

If you are unsure about the correct group, please do not leave the issue without a group label, and refer to GitLab's shared responsibility functionality guidelines for more information on how to triage this kind of issue.

This message was generated automatically. You're welcome to improve it.

This issue was automatically tagged with the label groupthreat insights by TanukiStan, a machine learning classification model, with a probability of 0.6.

If this label is incorrect, please tag this issue with the correct group label as well as automation:ml wrong to help TanukiStan learn from its mistakes.

If you are unsure about the correct group, please do not leave the issue without a group label. Please refer to GitLab's shared responsibility functionality guidelines for more information on how to triage this kind of issues.

Authors who do not have permission to update labels can leave the issue to be triaged by group leaders initially assigned by TanukiStan

This message was generated automatically. You're welcome to improve it.