Move header_ci_component.vue from vue_shared to the jobs area
Summary
Currently app/assets/javascripts/vue_shared/components/header_ci_component.vue
is part of vue_shared
even though it is only used in the jobs area, it seems that previously it was used in as the pipeline header but that is no longer the case.
We should:
- Move the
app/assets/javascripts/vue_shared/components/header_ci_component.vue
toapp/assets/javascripts/jobs/components/job/
- Rename the component and it's references to
job_header
. - Have one more look at test selectors like
data-testid="ci-header-content"
to see if we can update them or remove them.
Improvements
Our vue_shared
is handled differently from other components because it is meant to be more reusable. This component does not fit that description and this can confuse internal and external contributors
Risks
We should ensure the job page is displayed correctly after this change, the risk I low as the verification is quick.
Involved components
Vue components:
app/assets/javascripts/vue_shared/components/header_ci_component.vue
app/assets/javascripts/jobs/components/job/job_app.vue
Original Discussion
The following discussion from !126339 (merged) should be addressed:
-
@mrincon started a discussion: (+1 comment) Thanks for this @pburdette, I checked the files related to this and found
app/assets/javascripts/vue_shared/components/header_ci_component.vue
which used to be used in the pipeline. I'll add a follow up to refactor as well.