Skip to content

[Feature Flag] Rollout `restrict_ci_job_token_for_public_and_internal_projects`

Summary

This issue is to rollout [Restricting job token for public and internal projects][#405369 (closed)] on production, that is currently behind the restrict_ci_job_token_for_public_and_internal_projects feature flag.

Owners

Stakeholders

Expectations

What are we expecting to happen?

We are restricting job tokens for public and internal projects.

  • For public/internal projects that have ci_job_token_inbound_scope enabled. Access to their container/packages/releases/artifacts will determine on the project's settings
  • If the calling project is not in the allowlist of the target project
    • If it's "Everyone with Access"
      • Then there are no checks required
    • If it's "Only for project members"
      • Then the calling project needs to be on the target project's ci_job_inbound_scope allowlist
    • If it's "Disabled"
      • No access is given
  • If the calling project is in the allowlist
    • There are no checks required
  • This change only affects inbound, as outbound is deprecated and scoped out

Summary of changes on restrictions: https://gitlab.com/gitlab-org/gitlab/-/issues/425322

When is the feature viable?

%16.6 release

What might happen if this goes wrong?

What can we monitor to detect problems with this?

Consider mentioning checks for 5xx errors or other anomalies like an increase in redirects (302 HTTP response status)

What can we check for monitoring production after rollouts?

Consider adding links to check for Sentry errors, Production logs for 5xx, 302s, etc.

Rollout Steps

Note: Please make sure to run the chatops commands in the slack channel that gets impacted by the command.

Rollout on non-production environments

  • Verify the MR with the feature flag is merged to master.
  • Verify that the feature MRs have been deployed to non-production environments with:
    • /chatops run auto_deploy status <merge-commit-of-your-feature>
  • Enable the feature globally on non-production environments.
    • /chatops run feature set restrict_ci_job_token_for_public_and_internal_projects true --dev --staging --staging-ref
    • If the feature flag causes QA end-to-end tests to fail:
      • Disable the feature flag on staging to avoid blocking deployments.
  • Verify that the feature works as expected. Posting the QA result in this issue is preferable. The best environment to validate the feature in is staging-canary as this is the first environment deployed to. Note you will need to make sure you are configured to use canary as outlined here when accessing the staging environment in order to make sure you are testing appropriately.

For assistance with QA end-to-end test failures, please reach out via the #quality Slack channel. Note that QA test failures on staging-ref don't block deployments.

Specific rollout on production

For visibility, all /chatops commands that target production should be executed in the #production slack channel and cross-posted (with the command results) to the responsible team's slack channel (#g_TEAM_NAME).

  • Ensure that the feature MRs have been deployed to both production and canary.
    • /chatops run auto_deploy status <merge-commit-of-your-feature>
  • Depending on the type of actor you are using, pick one of these options:
    • If you're using project-actor, you must enable the feature on these entries:
      • /chatops run feature set --project=gitlab-org/gitlab,gitlab-org/gitlab-foss,gitlab-com/www-gitlab-com restrict_ci_job_token_for_public_and_internal_projects true
    • If you're using group-actor, you must enable the feature on these entries:
      • /chatops run feature set --group=gitlab-org,gitlab-com restrict_ci_job_token_for_public_and_internal_projects true
    • If you're using user-actor, you must enable the feature on these entries:
      • /chatops run feature set --user=<your-username> restrict_ci_job_token_for_public_and_internal_projects true
  • Verify that the feature works on the specific entries. Posting the QA result in this issue is preferable.

Preparation before global rollout

  • Set a milestone to the rollout issue to signal for enabling and removing the feature flag when it is stable.
  • Check if the feature flag change needs to be accompanied with a change management issue. Cross link the issue here if it does.
  • Ensure that you or a representative in development can be available for at least 2 hours after feature flag updates in production. If a different developer will be covering, or an exception is needed, please inform the oncall SRE by using the @sre-oncall Slack alias.
  • Ensure that documentation has been updated (More info).
  • Leave a comment on the feature issue announcing estimated time when this feature flag will be enabled on GitLab.com.
  • Ensure that any breaking changes have been announced following the release post process to ensure GitLab customers are aware.
  • Notify #support_gitlab-com and your team channel (more guidance when this is necessary in the dev docs).
  • Ensure that the feature flag rollout plan is reviewed by another developer familiar with the domain.

Global rollout on production

For visibility, all /chatops commands that target production should be executed in the #production slack channel and cross-posted (with the command results) to the responsible team's slack channel (#g_TEAM_NAME).

  • Incrementally roll out the feature.
    • Between every step wait for at least 15 minutes and monitor the appropriate graphs on https://dashboards.gitlab.net.
    • If the feature flag in code has an actor, perform actor-based rollout.
      • /chatops run feature set restrict_ci_job_token_for_public_and_internal_projects <rollout-percentage> --actors
    • If the feature flag in code does NOT have an actor, perform time-based rollout (random rollout).
      • /chatops run feature set restrict_ci_job_token_for_public_and_internal_projects <rollout-percentage> --random
    • Enable the feature globally on production environment.
      • /chatops run feature set restrict_ci_job_token_for_public_and_internal_projects true
  • Observe appropriate graphs on https://dashboards.gitlab.net and verify that services are not affected.
  • Leave a comment on the feature issue announcing that the feature has been globally enabled.
  • Wait for at least one day for the verification term.

(Optional) Release the feature with the feature flag

If you're still unsure whether the feature is deemed stable but want to release it in the current milestone, you can change the default state of the feature flag to be enabled. To do so, follow these steps:

  • Create a merge request with the following changes. Ask for review and merge it.
  • Ensure that the default-enabling MR has been included in the release package. If the merge request was deployed before the monthly release was tagged, the feature can be officially announced in a release blog post.
    • /chatops run release check <merge-request-url> <milestone>
  • Consider cleaning up the feature flag from all environments by running these chatops command in #production channel. Otherwise these settings may override the default enabled.
    • /chatops run feature delete restrict_ci_job_token_for_public_and_internal_projects --dev --staging --staging-ref --production
  • Close the feature issue to indicate the feature will be released in the current milestone.
  • Set the next milestone to this rollout issue for scheduling the flag removal.
  • (Optional) You can create a separate issue for scheduling the steps below to Release the feature.
    • Set the title to "[Feature flag] Cleanup restrict_ci_job_token_for_public_and_internal_projects".
    • Execute the /copy_metadata <this-rollout-issue-link> quick action to copy the labels from this rollout issue.
    • Link this rollout issue as a related issue.
    • Close this rollout issue.

WARNING: This approach has the downside that it makes it difficult for us to clean up the flag. For example, on-premise users could disable the feature on their GitLab instance. But when you remove the flag at some point, they suddenly see the feature as enabled and they can't roll it back to the previous behavior. To avoid this potential breaking change, use this approach only for urgent matters.

Release the feature

After the feature has been deemed stable, the clean up should be done as soon as possible to permanently enable the feature and reduce complexity in the codebase.

You can either create a follow-up issue for Feature Flag Cleanup or use the checklist below in this same issue.

  • Create a merge request to remove restrict_ci_job_token_for_public_and_internal_projects feature flag. Ask for review and merge it.
    • Remove all references to the feature flag from the codebase.
    • Remove the YAML definitions for the feature from the repository.
    • Create a changelog entry.
  • Ensure that the cleanup MR has been included in the release package. If the merge request was deployed before the monthly release was tagged, the feature can be officially announced in a release blog post.
    • /chatops run release check <merge-request-url> <milestone>
  • Close the feature issue to indicate the feature will be released in the current milestone.
  • Clean up the feature flag from all environments by running these chatops command in #production channel:
    • /chatops run feature delete restrict_ci_job_token_for_public_and_internal_projects --dev --staging --staging-ref --production
  • Close this rollout issue.

Rollback Steps

  • This feature can be disabled by running the following Chatops command:
/chatops run feature set restrict_ci_job_token_for_public_and_internal_projects false
Edited by Dmytro Biryukov