Skip to content

Add style to email with subject "Two-factor authentication disabled"

Problem description

Here are some emails that GitLab sends that currently look totally unstyled:

Screenshot_2023-07-05_at_9.13.58_PM

Source code for email above: https://gitlab.com/gitlab-org/gitlab/-/blob/a679324a3a668b1548f0b5394e0c2874f6c8cf9f/app/mailers/emails/profile.rb#L73-84

Screenshot_2023-07-05_at_9.11.00_PM

Source code for email above: https://gitlab.com/gitlab-org/gitlab/-/blob/a679324a3a668b1548f0b5394e0c2874f6c8cf9f/app/mailers/emails/profile.rb#L160-168

It would be great if all of our notification emails had some styles so they look more official.

Like this email:

Screenshot_2023-07-05_at_9.11.33_PM

Which is added as part of this MR: !124577 (merged)

There is an issue requesting that styles be added to all emails: Improve default email template styling (#215652)

But what if we start with the 2 in the screenshots above? Can we make those look nice?

Implementation guide

For emails without a layout:

Edited by Jessie Young