Follow-up from "Add missing trailing breadcrumbs for analytics dashboard pages"
The following discussion from !124418 (merged) should be addressed:
-
@rob.hunt started a discussion: (+2 comments) note: For more information on this approach, see the MR description.
frontend - 1️⃣
Implementation plan - - Create shared utility to inject breadcrumbs
- Needs to accept the
router
- Needs to accept a component name to add to the Vue initialization
- Needs to support adding
apolloProvider
if it exists
- Needs to accept the
- Update https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/packages_and_registries/shared/utils.js#L43 to use the new utility
- Update https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/assets/javascripts/analytics/analytics_dashboards/index.js#L16 to use the new utility
- Add new utility spec
- Update specs if required
Edited by Robert Hunt