GitlabServicePingWorker will start over and over, even if usage statistics are completely disabled on self-hosted
Summary
Since 16.1, on self-hosted, even if usage statistics are completely disabled the GitlabServicePingWorker will start, trying to contact Gitlab.
As the environment is air-gapped, this naturally fail.
Steps to reproduce
- Upgrade to 16.1 with usage statistics completely disabled
- Observe the background jobs in /admin/background_jobs
- Notice two jobs running, that are related to the usage statistics
Relevant logs and/or screenshots
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Current User: git Using RVM: no Ruby Version: 3.0.6p216 Gem Version: 3.4.13 Bundler Version:2.4.14 Rake Version: 13.0.6 Redis Version: 6.2.11 Sidekiq Version:6.5.7 Go Version: unknown GitLab information Version: 16.1.1 Revision: 9ce736bb2cd Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 13.10 URL: https://example.gitlab.com HTTP Clone URL: https://example.gitlab.com/some-group/some-project.git SSH Clone URL: git@example.gitlab.com:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers: openid_connect, openid_connect_2fa, openid_connect_aad GitLab Shell Version: 14.23.0 Repository storages: - default: tls://...:8075 - gitaly-05: tls://...:8075 - gitaly-06: tls://...:8075 - gitaly-07: tls://...:8075 GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell ```
Possible fixes
https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/version_check.rb
/cc @fh1ch
Edited by 🤖 GitLab Bot 🤖

