Skip to content

Flaky test spec/migrations/cleanup_bigint_conversion_for_merge_request_metrics_for_self_hosts_spec.rb

Summary

Steps to reproduce

Please refer to Flaky tests documentation to learn more about how to reproduce them.

Proposed Resolution

Please refer to the Resolution guidance to learn more about resolution of broken master.

Once the flaky failure has been fixed on the default branch, open merge requests to cherry-pick the fix to the active stable branches.

Job #4519210692 failed for db3260ae:

  1) CleanupBigintConversionForMergeRequestMetricsForSelfHosts#up when is a self-host customer with the temporary column already dropped does nothing
     Failure/Error: expect(merge_request_metrics.columns.find { |c| c.name == 'id' }.sql_type).to eq('bigint')
       expected: "bigint"
            got: "integer"
       (compared using ==)
     # ./spec/migrations/cleanup_bigint_conversion_for_merge_request_metrics_for_self_hosts_spec.rb:63:in `block (4 levels) in <main>'
     # ./spec/spec_helper.rb:418:in `block (3 levels) in <top (required)>'
     # ./spec/support/sidekiq_middleware.rb:18:in `with_sidekiq_server_middleware'
     # ./spec/spec_helper.rb:409:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:405:in `block (3 levels) in <top (required)>'
     # ./lib/gitlab/application_context.rb:61:in `with_raw_context'
     # ./spec/spec_helper.rb:405:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:242:in `block (2 levels) in <top (required)>'
     # ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <main>'
     # ./spec/support/migration.rb:53:in `block (2 levels) in <main>'
     # ./spec/support/fast_quarantine.rb:23:in `block (2 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (3 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:60:in `with_cross_joins_prevented'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (2 levels) in <main>'
  2) CleanupBigintConversionForMergeRequestMetricsForSelfHosts#up when is a self-host with the temporary columns drop the temporary columns
     Failure/Error: expect(merge_request_metrics.columns.find { |c| c.name == 'id' }.sql_type).to eq('bigint')
       expected: "bigint"
            got: "integer"
       (compared using ==)
     # ./spec/migrations/cleanup_bigint_conversion_for_merge_request_metrics_for_self_hosts_spec.rb:88:in `block (7 levels) in <main>'
     # ./spec/support/helpers/migrations_helpers.rb:197:in `reversible_migration'
     # ./spec/migrations/cleanup_bigint_conversion_for_merge_request_metrics_for_self_hosts_spec.rb:84:in `block (5 levels) in <main>'
     # ./spec/support/helpers/migrations_helpers.rb:155:in `disable_migrations_output'
     # ./spec/migrations/cleanup_bigint_conversion_for_merge_request_metrics_for_self_hosts_spec.rb:83:in `block (4 levels) in <main>'
     # ./spec/spec_helper.rb:418:in `block (3 levels) in <top (required)>'
     # ./spec/support/sidekiq_middleware.rb:18:in `with_sidekiq_server_middleware'
     # ./spec/spec_helper.rb:409:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:405:in `block (3 levels) in <top (required)>'
     # ./lib/gitlab/application_context.rb:61:in `with_raw_context'
     # ./spec/spec_helper.rb:405:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:242:in `block (2 levels) in <top (required)>'
     # ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <main>'
     # ./spec/support/migration.rb:53:in `block (2 levels) in <main>'
     # ./spec/support/fast_quarantine.rb:23:in `block (2 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (3 levels) in <main>'
     # ./spec/support/database/prevent_cross_joins.rb:60:in `with_cross_joins_prevented'
     # ./spec/support/database/prevent_cross_joins.rb:106:in `block (2 levels) in <main>'
Finished in 42.49 seconds (files took 40.53 seconds to load)
2 examples, 2 failures
Failed examples:
rspec ./spec/migrations/cleanup_bigint_conversion_for_merge_request_metrics_for_self_hosts_spec.rb:54 # CleanupBigintConversionForMergeRequestMetricsForSelfHosts#up when is a self-host customer with the temporary column already dropped does nothing
rspec ./spec/migrations/cleanup_bigint_conversion_for_merge_request_metrics_for_self_hosts_spec.rb:76 # CleanupBigintConversionForMergeRequestMetricsForSelfHosts#up when is a self-host with the temporary columns drop the temporary columns
Randomized with seed 6280
[TEST PROF INFO] Time spent in factories: 00:00.023 (0.05% of total time)