Audit event stream HTTP header: empty status
Problem
Follow up from the comment
Use the empty status(See solution part) instead of having a blank row of key-value pair
Because when we have the empty row, we also show the delete icon, but the delete does work, and also we show it after the user has a value-key pair, the user has one value pair, but we show two lines; it is a bit confusing. I recorded a video to explain myself; I hope it helps!
Solution
Implementation steps
- do not create blank header automatically on mounted or when deleting a header in
stream_destination_editor.vue
- show label "No header created yet" in secondary color if no header has been added in
stream_destination_editor.vue
- refactor spec
stream_destination_editor_spec.js
Verification steps
- go to issue-reproduce audit event streams
- Select the destination url to expand
- Verify that it mentions there is no header added: "No header created yet."
- Select "Add header" button
- Verify it still adds a header row
- Verify that if you add 20 header rows, it still shows the message: "Maximum of 20 HTTP headers has been reached." and hides the "Add header" button
Edited by Lorenz van Herwaarden