Follow-up from "Release Security Reports V2"
The following discussion from !122433 (merged) should be addressed:
-
@dftian started a discussion: suggestion (optional): I believe we can also remove the deprecated code in the EE version. Not 100% sure about
mr.enabledReports
, but I think the security widget handles it internally now.Index: ee/app/assets/javascripts/vue_merge_request_widget/components/widget/app.vue IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== diff --git a/ee/app/assets/javascripts/vue_merge_request_widget/components/widget/app.vue b/ee/app/assets/javascripts/vue_merge_request_widget/components/widget/app.vue --- a/ee/app/assets/javascripts/vue_merge_request_widget/components/widget/app.vue (revision 97fe65ea387806d655c255d8fcf2890d6c03ddff) +++ b/ee/app/assets/javascripts/vue_merge_request_widget/components/widget/app.vue (date 1686044847406) @@ -15,29 +15,9 @@ extends: CEWidgetApp, - securityReportTypes: [ - 'dast', - 'sast', - 'dependencyScanning', - 'containerScanning', - 'coverageFuzzing', - 'apiFuzzing', - 'secretDetection', - ], - computed: { - securityReportsWidget() { - const { enabledReports } = this.mr; - - return enabledReports && - this.mr.canReadVulnerabilities && - this.$options.securityReportTypes.some((reportType) => enabledReports[reportType]) - ? 'MrSecurityWidgetEE' - : 'MrSecurityWidgetCE'; - }, - widgets() { - return [this.securityReportsWidget].filter((w) => w); + return [this.mr.canReadVulnerabilities ? 'MrSecurityWidgetEE' : 'MrSecurityWidgetCE']; }, },
Verification steps
-
Go to gitlab-examples/security/security-reports!114 (closed) -
Make sure the security widget is loading
Edited by Lorenz van Herwaarden