Skip to content

Geo tries to verify non-existing design repositories

Summary

Once design repositories have been migrated to SSF imported projects from Github and other vendors can potentially result in a situation where potentially the design repository is not initialised similarly to what we have seen with project wikis here. The result is Geo complaining that the design repository cannot be checksummed.

This will impact customers who have imported projects in the past and customers who will import projects into Gitlab in the future.

Update This problem can also arise when a DesignManagement::Repository object exists for a project that doesn't have designs. This is because a backfill introduced these objects for all projects, even those without design repos.

Creating this issue pre-emptively without having reproduced this based on issues seen when project wikis were moved to SSF and similarities shared between project wikis and design repositories.

Steps to reproduce

Similar to #409704 (closed)

What is the current bug behavior?

I have not been able to test this myself since the new SSF workflow for design repositories is not available yet. However, based on similarities between project wikis and design repositories and comments here #409704 (comment 1380019138) it is likely design repositories will also exhibit this behaviour.

What is the expected correct behavior?

Repository cannot be checksummed because it does not exist errors should not occur.

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)


(we will only investigate if the tests are passing)

Workaround

Disable the feature flag geo_design_management_repository_replication.

Feature.disable(geo_design_management_repository_replication)

Possible fixes

!123917 (merged) will fix the issue in %16.2

Edited by Aakriti Gupta