Loading a board updates the URL with multiple milestone_titles
Summary
Loading an issue board appends the board scope to the URL. When the user loads a board which has changed scope, the milestone_title
attribute is added multiple times to the URL. This causes strange side-effects, such as the blue dot appearing next to 'Edit Board' even though no scope has changed.
Steps to reproduce
- Set up a board with a milestone in the scope.
- Bookmark this board.
- Change the milestone scope of the board.
- Visit the bookmark and let the page load.
- Note the URL has been changed to have both
milestone_title
attributes in the query string & strange behavior on the board itself.
Example Project
Use the Knowledge Build Board bookmark: https://gitlab.com/groups/gitlab-org/-/boards/5454834?milestone_title=15.11&label_name[]=group%3A%3Aknowledge
What is the current bug behavior?
Both milestone_titles are in the URL
What is the expected correct behavior?
The milestone_title
should be added-or-updated in the URL instead of simply added.
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: \`sudo gitlab-rake gitlab:env:info\`) (For installations from source run and paste the output of: \`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production\`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:check SANITIZE=true`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`) (we will only investigate if the tests are passing)