Avoid sentence splitting in status_description
Following this comment about sentence splitting that was being done, I noticed this is already the case in ee/app/assets/javascripts/vulnerabilities/components/status_description.vue
.
This should be fixed by including ': %{dismissalReason}'
in the string.
e.g.: s__('VulnerabilityManagement|%{statusStart}Dismissed%{statusEnd}: %{dismissalReason} %{timeago} by %{user}');
A helper ee/app/assets/javascripts/vue_shared/security_reports/components/helpers.js
was introduced in that MR, perhaps something similar can be implemented or the helper can be made more generic?
Verification
- Go to https://gitlab.com/gitlab-examples/security/security-reports/
- Click on Secure > Vulnerability Report
- Change the status of a vulnerability (use the checkbox next to the vulnerability to have the status selector displayed)
- Check the translation
Edited by Savas Vedova