Show dismissal reason in finding modal
Summary
Show the dismissal reason in the finding modal.
While the DismissalNote component is used both in the old and new modal, we'll only support showing the dismissal reason in the new one (VulnerabilityFindingModal).
Screenshots
Implementation steps
- add
dismissalReason
insecurity_report_finding.query.graphql
- pass
dismissalReason
indismissalFeedback
in VulnerabilityFindingModal to DismissalNote - update
eventText()
to showdismissalReason
(if any) - update
dismissal_note_spec.js
andvulnerability_finding_modal_spec.js
accordingly
Verification steps
- Go to the security tab of a pipeline in this verification project (on staging.gitlab.com)
- It's already filtered on medium severities
- Find the vulnerability named "Double free" (it has been dismissed with reason earlier) and click on it
- Verify that in the note at the bottom in mentions "Dismissed: Mitigating control at Verify Show dismissal reason in finding modal"
Edited by Lorenz van Herwaarden