Expose merge time metrics on GraphQL flowMetrics
Merge time virtual stage was added with !117986 (merged) now we need to expose
it on GraphQL flowMetrics
node.
The following discussion from !117986 (merged) should be addressed:
-
@felipe_artur started a discussion: (+1 comment)
@cablett @ahegyi Do we need a follow-up to add time to merge stage into GraphQL
flowMetrics
?
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Felipe Cardozo added GraphQL devopsplan featureaddition groupoptimize labels
added GraphQL devopsplan featureaddition groupoptimize labels
- Felipe Cardozo set weight to 1
set weight to 1
- 🤖 GitLab Bot 🤖 added typefeature label
added typefeature label
- 🤖 GitLab Bot 🤖 added sectiondev label
added sectiondev label
- Author Maintainer
Collapse replies - Developer
cc @hsnir1
@felipe_artur @cablett once this will be ready, can we also count in VSD the Mean time to merge for projects and groups?
With support for "filter by label"?
cc @ahegyi
- Developer
I think the Group level MR metrics wasn't performant. @ahegyi can you confirm?
With support for "filter by label"?
I believe so. In our
DataCollector
we have support for labels. https://gitlab.com/gitlab-org/gitlab/blob/6bac45aeffa804f0a958437b081a431e2b6b3a07/ee/lib/gitlab/analytics/cycle_analytics/summary/base_time.rb#L67 and in the resolver we also allow for an option. So we can doquery { project(fullPath: "mygroup/myproject") { name timeToMerge(from: "2023-03-01", to: "2023-05-01", labelNames: ["awesome", "fantastic"]) { identifier links { name url } title unit value } } }
Edited by charlie ablett - Maintainer
I think the Group level MR metrics wasn't performant. @ahegyi can you confirm?
I think this came up when we added the link to the MR analytics feature. We didn't implement the group-level view because the group-level database queries for MR metrics were too slow. Reasoning: the query needs to join the
merge_request_metrics
table which causes way too many rows to be read.However, with our new in-memory Vsa stage, data is going to be collected and aggregated in the background so running VSA queries should be performant enough. The data collector already exposes the
average
method. - Developer
Great, thank you for the correction!
- Felipe Cardozo mentioned in merge request !117986 (merged)
mentioned in merge request !117986 (merged)
- Haim Snir changed milestone to %Next 1-3 releases
changed milestone to %Next 1-3 releases
- Maintainer
@felipe_artur is this ready for workflowscheduling?
Collapse replies - Author Maintainer
@blabuschagne Yes.
1
- Felipe Cardozo added workflowscheduling label
added workflowscheduling label
- Brandon Labuschagne added backend label
added backend label
- Maintainer
@hsnir1 can you please set the priority on this
1 - Brandon Labuschagne changed milestone to %16.6
changed milestone to %16.6
- Brandon Labuschagne added workflowready for development label and removed workflowscheduling label
added workflowready for development label and removed workflowscheduling label
- Brandon Labuschagne added Deliverable label
added Deliverable label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14515 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14515 (closed)
- Maintainer
Setting health status to
on track
as the milestone has just begun.Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to on track
changed health status to on track
- Maintainer
This feature issue does not have the
documentation
label. Please add it if appropriate, because documentation is one of the aspects of our MR acceptance checklist. - 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14610 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14610 (closed)
- Maintainer
This issue is scheduled for completion in this milestone but doesn't have an assignee. Changing health status to 'needs attention'.
Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to needs attention
changed health status to needs attention
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14676 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14676 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14794 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14794 (closed)
- Maintainer
This issue is scheduled for completion in this milestone but doesn't have an assignee. Changing health status to 'at risk'.
Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to at risk
changed health status to at risk
- Maintainer
@gitlab-org/plan-stage/optimize-group/engineers is this metric currently being displayed on the dashboard via REST, or not at all?
Reason I'm asking is that if it's not currently being displayed I think we can move this to %Next 1-3 releases else we can reschedule it for %16.7
Collapse replies - Maintainer
@blabuschagne, AFAIK it's not displayed anywhere. The REST API returns it but it's not presented on the FE: https://gitlab.com/groups/gitlab-org/-/analytics/value_stream_analytics/time_summary?created_after=2023-10-12&created_before=2023-11-10
- Maintainer
Thanks - I also looked at the dashboard and didn't see it anywhere, just wanted to make sure in case it was labelled as something else
1
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14889 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14889 (closed)
- Brandon Labuschagne changed milestone to %16.7
changed milestone to %16.7
- Brandon Labuschagne changed health status to on track
changed health status to on track
- Maintainer
This feature issue does not have the
documentation
label. Please add it if appropriate, because documentation is one of the aspects of our MR acceptance checklist. - 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14960 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14960 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15056 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15056 (closed)
- Maintainer
This issue is scheduled for completion in this milestone but doesn't have an assignee. Changing health status to 'needs attention'.
Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to needs attention
changed health status to needs attention
- 🤖 GitLab Bot 🤖 added 1 deleted label
added 1 deleted label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15170 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15170 (closed)
- Adam Hegyi assigned to @ahegyi
assigned to @ahegyi
- Adam Hegyi added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Adam Hegyi mentioned in merge request !139220 (merged)
mentioned in merge request !139220 (merged)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15265 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15265 (closed)
- Adam Hegyi added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Brandon Labuschagne changed health status to on track
changed health status to on track
- Adam Hegyi added workflowverification label and removed workflowin review label
added workflowverification label and removed workflowin review label
- Maintainer
Works on PRD:
{ group(fullPath: "gitlab-org") { id flowMetrics { timeToMerge(from: "2023-11-12", to: "2023-12-12") { value identifier unit } } } }
- Adam Hegyi closed
closed
- Adam Hegyi added workflowcomplete label and removed workflowverification label
added workflowcomplete label and removed workflowverification label
- Maintainer
@blabuschagne, I couldn't find the FE counterpart for this issue. Now we can expose the time to merge metric on VSD.
Collapse replies - Maintainer
Thanks @ahegyi! I think the closest issue we have is VSD - [FE] add "Closed issues" (FKA "Velocity")... (#386715 - closed) but there's none for this specific metric.
I've gone ahead and opened Add merge time metric to VSD - Median time to m... (#435451 - closed)
- Brandon Labuschagne marked this issue as related to #435451 (closed)
marked this issue as related to #435451 (closed)
- Brandon Labuschagne mentioned in issue #435451 (closed)
mentioned in issue #435451 (closed)
- Brandon Labuschagne added devopsmonitor label and removed devopsplan label
added devopsmonitor label and removed devopsplan label